Personal-Twin/hapi-fhir-jpaserver-starter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #753 from XcrigX/fix-cds-test-race

Browse Source 
fix intermittent error with CDS test
This commit is contained in:
dotasek
2024-10-31 16:14:46 -04:00
committed by GitHub
parent 48a141b749 85aab81237
commit 02e4de713e
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/test/java/ca/uhn/fhir/jpa/starter/CdsHooksServletIT.java
View File

@@ -88,7 +88,14 @@ class CdsHooksServletIT implements IServerSupport {
private Boolean hasCdsServices() throws IOException { private Boolean hasCdsServices() throws IOException {
var response = callCdsServicesDiscovery(); var response = callCdsServicesDiscovery();
return response.getEntity().getContentLength() > 21 || response.getEntity().isChunked();
// NOTE: this is looking for a repsonse that indicates there are CDS services availalble.
// And empty response looks like: {"services": []}
// Looking at the actual response string consumes the InputStream which has side-effects, making it tricky to compare the actual contents.
// Hence the test just looks at the length to make this determination.
// The actual response has newlines in it which vary in size on some systems, but a value of 25 seems to work across linux/mac/windows
// to ensure the repsonse actually contains CDS services in it
return response.getEntity().getContentLength() > 25 || response.getEntity().isChunked();
} }
private CloseableHttpResponse callCdsServicesDiscovery() { private CloseableHttpResponse callCdsServicesDiscovery() {