From 531d2557820b5ecbe725a9142dd231413a6dd716 Mon Sep 17 00:00:00 2001 From: Thomas Papke Date: Sat, 1 Oct 2022 17:19:01 +0200 Subject: [PATCH] Proper close DB connection after dialect was resolved (#435) --- .../jpa/starter/util/JpaHibernatePropertiesProvider.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/main/java/ca/uhn/fhir/jpa/starter/util/JpaHibernatePropertiesProvider.java b/src/main/java/ca/uhn/fhir/jpa/starter/util/JpaHibernatePropertiesProvider.java index 83125a9..696f348 100644 --- a/src/main/java/ca/uhn/fhir/jpa/starter/util/JpaHibernatePropertiesProvider.java +++ b/src/main/java/ca/uhn/fhir/jpa/starter/util/JpaHibernatePropertiesProvider.java @@ -8,6 +8,8 @@ import org.hibernate.engine.jdbc.dialect.spi.DatabaseMetaDataDialectResolutionIn import org.springframework.orm.jpa.LocalContainerEntityManagerFactoryBean; import javax.sql.DataSource; + +import java.sql.Connection; import java.sql.SQLException; public class JpaHibernatePropertiesProvider extends HibernatePropertiesProvider { @@ -16,9 +18,9 @@ public class JpaHibernatePropertiesProvider extends HibernatePropertiesProvider public JpaHibernatePropertiesProvider(LocalContainerEntityManagerFactoryBean myEntityManagerFactory) { DataSource connection = myEntityManagerFactory.getDataSource(); - try { + try ( Connection dbConnection = connection.getConnection()){ dialect = new StandardDialectResolver() - .resolveDialect(new DatabaseMetaDataDialectResolutionInfoAdapter(connection.getConnection().getMetaData())); + .resolveDialect(new DatabaseMetaDataDialectResolutionInfoAdapter(dbConnection.getMetaData())); } catch (SQLException sqlException) { throw new ConfigurationException(sqlException.getMessage(), sqlException); }