Personal-Twin/hapi-fhir-jpaserver-starter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

add comments to explain non-intuitive logic in test

Browse Source
This commit is contained in:
craig mcclendon
2024-10-31 12:27:33 -05:00
parent 04de3e738f
commit 85aab81237
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/test/java/ca/uhn/fhir/jpa/starter/CdsHooksServletIT.java
View File

@@ -88,6 +88,13 @@ class CdsHooksServletIT implements IServerSupport {
private Boolean hasCdsServices() throws IOException { private Boolean hasCdsServices() throws IOException {
var response = callCdsServicesDiscovery(); var response = callCdsServicesDiscovery();
// NOTE: this is looking for a repsonse that indicates there are CDS services availalble.
// And empty response looks like: {"services": []}
// Looking at the actual response string consumes the InputStream which has side-effects, making it tricky to compare the actual contents.
// Hence the test just looks at the length to make this determination.
// The actual response has newlines in it which vary in size on some systems, but a value of 25 seems to work across linux/mac/windows
// to ensure the repsonse actually contains CDS services in it
return response.getEntity().getContentLength() > 25 || response.getEntity().isChunked(); return response.getEntity().getContentLength() > 25 || response.getEntity().isChunked();
} }