Fix #122 - EMPI error on startup when EMPI not enabled

pom.xml

@@ -1,5 +1,6 @@
 <project xmlns="http://maven.apache.org/POM/4.0.0"
-    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <modelVersion>4.0.0</modelVersion>
 
     <!--
@@ -275,14 +276,6 @@
             <scope>test</scope>
         </dependency>
 
-        <!-- TODO: remove this and migrate to JU5 -->
-        <dependency>
-            <groupId>junit</groupId>
-            <artifactId>junit</artifactId>
-            <version>4.12</version>
-            <scope>test</scope>
-        </dependency>
-
     </dependencies>
 
     <build>
@@ -338,6 +331,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-failsafe-plugin</artifactId>
+                <version>3.0.0-M5</version>
                 <configuration>
                     <redirectTestOutputToFile>true</redirectTestOutputToFile>
                 </configuration>

src/main/java/ca/uhn/fhir/jpa/empi/EmpiConfig.java

@@ -1,15 +1,11 @@
-package ca.uhn.fhir.jpa.starter;
+package ca.uhn.fhir.jpa.empi;
 
-import ca.uhn.fhir.context.FhirContext;
 import ca.uhn.fhir.empi.api.IEmpiSettings;
 import ca.uhn.fhir.empi.rules.config.EmpiRuleValidator;
 import ca.uhn.fhir.empi.rules.config.EmpiSettings;
-import ca.uhn.fhir.jpa.empi.svc.EmpiSearchParamSvc;
+import ca.uhn.fhir.jpa.starter.HapiProperties;
-import ca.uhn.fhir.jpa.subscription.channel.subscription.IChannelNamer;
-import ca.uhn.fhir.rest.server.util.ISearchParamRetriever;
 import com.google.common.base.Charsets;
 import org.apache.commons.io.IOUtils;
-import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Configuration;
 import org.springframework.core.io.DefaultResourceLoader;
@@ -17,6 +13,10 @@ import org.springframework.core.io.Resource;
 
 import java.io.IOException;
 
+/**
+ * TODO: Move this to package "ca.uhn.fhir.jpa.starter" in HAPI FHIR 5.2.0+. The lousy component scan
+ * in 5.1.0 picks this up even if EMPI is disabled currently.
+ */
 @Configuration
 public class EmpiConfig {
 

src/main/java/ca/uhn/fhir/jpa/starter/ApplicationContext.java

@@ -1,6 +1,7 @@
 package ca.uhn.fhir.jpa.starter;
 
 import ca.uhn.fhir.context.FhirVersionEnum;
+import ca.uhn.fhir.jpa.empi.EmpiConfig;
 import ca.uhn.fhir.jpa.empi.config.EmpiConsumerConfig;
 import ca.uhn.fhir.jpa.empi.config.EmpiSubmitterConfig;
 import ca.uhn.fhir.jpa.subscription.channel.config.SubscriptionChannelConfig;

src/main/resources/empi-rules.json

@@ -1,4 +1,5 @@
 {
+  "version": "1",
   "candidateSearchParams": [
     {
       "resourceType": "Patient",

src/test/java/ca/uhn/fhir/jpa/starter/ExampleServerDstu2IT.java

@@ -9,13 +9,13 @@ import ca.uhn.fhir.test.utilities.JettyUtil;
 import org.eclipse.jetty.server.Server;
 import org.eclipse.jetty.webapp.WebAppContext;
 import org.hl7.fhir.instance.model.api.IIdType;
-import org.junit.AfterClass;
+import org.junit.jupiter.api.AfterAll;
-import org.junit.BeforeClass;
+import org.junit.jupiter.api.BeforeAll;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
 import java.nio.file.Paths;
 
-import static org.junit.Assert.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertEquals;
 
 public class ExampleServerDstu2IT {
 
@@ -45,12 +45,12 @@ public class ExampleServerDstu2IT {
 		assertEquals(methodName, pt2.getName().get(0).getFamily().get(0).getValue());
 	}
 
-	@AfterClass
+	@AfterAll
 	public static void afterClass() throws Exception {
 		ourServer.stop();
 	}
 
-	@BeforeClass
+	@BeforeAll
 	public static void beforeClass() throws Exception {
 		String path = Paths.get("").toAbsolutePath().toString();
 

src/test/java/ca/uhn/fhir/jpa/starter/ExampleServerDstu3IT.java

@@ -18,9 +18,9 @@ import org.hl7.fhir.dstu3.model.Observation;
 import org.hl7.fhir.dstu3.model.Patient;
 import org.hl7.fhir.dstu3.model.Subscription;
 import org.hl7.fhir.instance.model.api.IIdType;
-import org.junit.AfterClass;
+import org.junit.jupiter.api.AfterAll;
-import org.junit.BeforeClass;
+import org.junit.jupiter.api.BeforeAll;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
 import java.net.URI;
 import java.nio.file.Paths;
@@ -28,7 +28,7 @@ import java.util.concurrent.Future;
 import java.util.concurrent.TimeUnit;
 
 import static ca.uhn.fhir.util.TestUtil.waitForSize;
-import static org.junit.Assert.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertEquals;
 
 public class ExampleServerDstu3IT {
 
@@ -119,12 +119,12 @@ public class ExampleServerDstu3IT {
     ourClient.delete().resourceById(mySubscriptionId).execute();
   }
 
-	@AfterClass
+  @AfterAll
   public static void afterClass() throws Exception {
     ourServer.stop();
   }
 
-	@BeforeClass
+  @BeforeAll
   public static void beforeClass() throws Exception {
     String path = Paths.get("").toAbsolutePath().toString();
 

src/test/java/ca/uhn/fhir/jpa/starter/ExampleServerR4IT.java

@@ -21,9 +21,9 @@ import org.hl7.fhir.r4.model.Patient;
 import org.hl7.fhir.r4.model.Person;
 import org.hl7.fhir.r4.model.Reference;
 import org.hl7.fhir.r4.model.Subscription;
-import org.junit.AfterClass;
+import org.junit.jupiter.api.AfterAll;
-import org.junit.BeforeClass;
+import org.junit.jupiter.api.BeforeAll;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
 import java.net.URI;
 import java.nio.file.Paths;
@@ -35,8 +35,8 @@ import java.util.concurrent.TimeUnit;
 
 import static ca.uhn.fhir.util.TestUtil.waitForSize;
 import static org.awaitility.Awaitility.await;
-import static org.junit.Assert.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.Assert.assertTrue;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
 public class ExampleServerR4IT {
 
@@ -61,6 +61,9 @@ public class ExampleServerR4IT {
         String methodName = "testCreateResourceConditional";
 
         Patient pt = new Patient();
+        pt.setActive(true);
+        pt.getBirthDateElement().setValueAsString("2020-01-01");
+        pt.addIdentifier().setSystem("http://foo").setValue("12345");
         pt.addName().setFamily(methodName);
         IIdType id = ourClient.create().resource(pt).execute().getId();
 
@@ -151,12 +154,12 @@ public class ExampleServerR4IT {
     return ourClient.search().forResource(Subscription.class).where(Subscription.STATUS.exactly().code("active")).cacheControl(new CacheControlDirective().setNoCache(true)).returnBundle(Bundle.class).execute().getEntry().size();
   }
 
-  @AfterClass
+  @AfterAll
     public static void afterClass() throws Exception {
         ourServer.stop();
     }
 
-    @BeforeClass
+    @BeforeAll
     public static void beforeClass() throws Exception {
         String path = Paths.get("").toAbsolutePath().toString();
 

src/test/java/ca/uhn/fhir/jpa/starter/ExampleServerR5IT.java

@@ -20,9 +20,9 @@ import org.hl7.fhir.r5.model.Observation;
 import org.hl7.fhir.r5.model.Patient;
 import org.hl7.fhir.r5.model.Subscription;
 import org.hl7.fhir.r5.model.SubscriptionTopic;
-import org.junit.AfterClass;
+import org.junit.jupiter.api.AfterAll;
-import org.junit.BeforeClass;
+import org.junit.jupiter.api.BeforeAll;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
 import java.net.URI;
 import java.nio.file.Paths;
@@ -30,7 +30,8 @@ import java.util.concurrent.Future;
 import java.util.concurrent.TimeUnit;
 
 import static ca.uhn.fhir.util.TestUtil.waitForSize;
-import static org.junit.Assert.assertEquals;
+import static org.awaitility.Awaitility.await;
+import static org.junit.jupiter.api.Assertions.assertEquals;
 
 public class ExampleServerR5IT {
 
@@ -111,13 +112,10 @@ public class ExampleServerR5IT {
     obs.setStatus(Enumerations.ObservationStatus.FINAL);
     ourClient.create().resource(obs).execute();
 
-    // Give some time for the subscription to deliver
-    Thread.sleep(2000);
-
     /*
      * Ensure that we receive a ping on the websocket
      */
-    waitForSize(1, () -> mySocketImplementation.myPingCount);
+    await().until(()->mySocketImplementation.myPingCount > 0);
 
     /*
      * Clean up
@@ -125,12 +123,12 @@ public class ExampleServerR5IT {
     ourClient.delete().resourceById(mySubscriptionId).execute();
   }
 
-  @AfterClass
+  @AfterAll
   public static void afterClass() throws Exception {
     ourServer.stop();
   }
 
-  @BeforeClass
+  @BeforeAll
   public static void beforeClass() throws Exception {
     String path = Paths.get("").toAbsolutePath().toString();
 

src/test/java/ca/uhn/fhir/jpa/starter/MultitenantServerR4IT.java

@@ -15,13 +15,13 @@ import org.hl7.fhir.r4.model.CodeType;
 import org.hl7.fhir.r4.model.IntegerType;
 import org.hl7.fhir.r4.model.Parameters;
 import org.hl7.fhir.r4.model.Patient;
-import org.junit.AfterClass;
+import org.junit.jupiter.api.AfterAll;
-import org.junit.BeforeClass;
+import org.junit.jupiter.api.BeforeAll;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
 import java.nio.file.Paths;
 
-import static org.junit.Assert.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertEquals;
 
 public class MultitenantServerR4IT {
 
@@ -94,12 +94,12 @@ public class MultitenantServerR4IT {
     assertEquals("Family B", pt2.getName().get(0).getFamily());
   }
 
-  @AfterClass
+  @AfterAll
   public static void afterClass() throws Exception {
     ourServer.stop();
   }
 
-  @BeforeClass
+  @BeforeAll
   public static void beforeClass() throws Exception {
     String path = Paths.get("").toAbsolutePath().toString();